linux-kernel - Re: [PATCH 2/2] remoteproc: qcom: pas: add SDM845 SLPI resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91875b7f6f77d6bc846e2da6d009b44c89cbafab.camel@dylanvanassche.be>
Date:   Mon, 27 Mar 2023 11:34:47 +0200
From:   Dylan Van Assche <me@...anvanassche.be>
To:     Konrad Dybcio <konrad.dybcio@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     Manivannan Sadhasivam <mani@...nel.org>,
        linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org
Subject: Re: [PATCH 2/2] remoteproc: qcom: pas: add SDM845 SLPI resource

Hi Konrad,

On Mon, 2023-03-27 at 10:44 +0200, Konrad Dybcio wrote:
> 
> 
> On 25.03.2023 14:21, Dylan Van Assche wrote:
> > Add SLPI resources for the SDM845 Qualcomm SoC to the Qualcomm
> > remoteproc q6v5_pas driver to define the default firmware name
> > and GLink edge name.
> > 
> > Signed-off-by: Dylan Van Assche <me@...anvanassche.be>
> > ---
> >  drivers/remoteproc/qcom_q6v5_pas.c | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> > 
> > diff --git a/drivers/remoteproc/qcom_q6v5_pas.c
> > b/drivers/remoteproc/qcom_q6v5_pas.c
> > index c99a20542685..d82b6f4bced4 100644
> > --- a/drivers/remoteproc/qcom_q6v5_pas.c
> > +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> > @@ -1028,6 +1028,22 @@ static const struct adsp_data
> > slpi_resource_init = {
> >                 .ssctl_id = 0x16,
> >  };
> >  
> > +static const struct adsp_data sdm845_slpi_resource = {
> > +               .crash_reason_smem = 424,
> > +               .firmware_name = "slpi.mdt",
> > +               .pas_id = 12,
> > +               .auto_boot = true,
> > +               .proxy_pd_names = (char*[]){
> > +                       "lcx",
> > +                       "lmx",
> > +                       NULL
> > +               },
> > +               .load_state = "slpi",
> > +               .ssr_name = "dsps",
> > +               .sysmon_name = "slpi",
> > +               .ssctl_id = 0x16,
> Isn't this identical to sm8150_slpi_resource?
> 
> Konrad

Yes it is. I added a new entry because for SM8150, SM8250, and SM8350
they are duplicated as well. The SDM845's struct is indentical to
SM8150/SM8250/SM8350's structs.

Kind regards,
Dylan Van Assche

> > +};
> > +
> >  static const struct adsp_data sm8150_slpi_resource = {
> >                 .crash_reason_smem = 424,
> >                 .firmware_name = "slpi.mdt",
> > @@ -1201,6 +1217,7 @@ static const struct of_device_id
> > adsp_of_match[] = {
> >         { .compatible = "qcom,sdm660-adsp-pas", .data =
> > &adsp_resource_init},
> >         { .compatible = "qcom,sdm845-adsp-pas", .data =
> > &sdm845_adsp_resource_init},
> >         { .compatible = "qcom,sdm845-cdsp-pas", .data =
> > &sdm845_cdsp_resource_init},
> > +       { .compatible = "qcom,sdm845-slpi-pas", .data =
> > &sdm845_slpi_resource},
> >         { .compatible = "qcom,sdx55-mpss-pas", .data =
> > &sdx55_mpss_resource},
> >         { .compatible = "qcom,sm6115-adsp-pas", .data =
> > &adsp_resource_init},
> >         { .compatible = "qcom,sm6115-cdsp-pas", .data =
> > &cdsp_resource_init},