linux-kernel - Re: [PATCH v4 1/8] dt-bindings: phy: qcom,qusb2: Document IPQ9574 compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <24bcba8e-11e7-ecce-0e08-c9def6cc54e8@linaro.org>
Date:   Mon, 27 Mar 2023 13:02:18 +0300
From:   Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To:     Varadarajan Narayanan <quic_varada@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, vkoul@...nel.org,
        kishon@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, gregkh@...uxfoundation.org,
        mturquette@...libre.com, sboyd@...nel.org, quic_wcheng@...cinc.com,
        linux-arm-msm@...r.kernel.org, linux-phy@...ts.infradead.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-clk@...r.kernel.org
Subject: Re: [PATCH v4 1/8] dt-bindings: phy: qcom,qusb2: Document IPQ9574
 compatible

On 27/03/2023 12:30, Varadarajan Narayanan wrote:
> Document the compatible string used for the qusb2 phy in IPQ9574.
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
> 
> ---
>   Changes in v4:
> 	- Remove constraints not applicable to IPQ9574

I don't think this is a correct way to go

>   Changes in v3:
> 	- Maintain the proper sorted order
> 
>   Changes in v2:
> 	- Moved ipq6018 to the proper place and placed ipq9574
> 	  next to it as suggested by Dmitry
> ---
>   Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> index 7f403e7..3cb27da 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qusb2-phy.yaml
> @@ -18,13 +18,14 @@ properties:
>       oneOf:
>         - items:
>             - enum:
> +              - qcom,ipq6018-qusb2-phy
>                 - qcom,ipq8074-qusb2-phy
> +              - qcom,ipq9574-qusb2-phy
>                 - qcom,msm8953-qusb2-phy
>                 - qcom,msm8996-qusb2-phy
>                 - qcom,msm8998-qusb2-phy
>                 - qcom,qcm2290-qusb2-phy
>                 - qcom,sdm660-qusb2-phy
> -              - qcom,ipq6018-qusb2-phy
>                 - qcom,sm4250-qusb2-phy
>                 - qcom,sm6115-qusb2-phy
>         - items:
> @@ -157,9 +158,6 @@ required:
>     - "#phy-cells"
>     - clocks
>     - clock-names
> -  - vdd-supply
> -  - vdda-pll-supply
> -  - vdda-phy-dpdm-supply

So, how does ipq9574 power on the PHY?

>     - resets
>   
>   allOf:

-- 
With best wishes
Dmitry