linux-kernel - Re: [git pull] common helper for kmap_local

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2023 12:20:23 +0200
From:   "Fabio M. De Francesco" <fmdefrancesco@...il.com>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        ira.weiny@...el.com
Subject: Re: [git pull] common helper for kmap_local_page() users in local filesystems

On sabato 11 marzo 2023 18:11:01 CEST Fabio M. De Francesco wrote:
> On venerdì 10 marzo 2023 21:44:31 CET Al Viro wrote:
> > 	kmap_local_page() conversions in local filesystems keep running into
> > 
> > kunmap_local_page()+put_page() combinations; we can keep inventing names
> > for identical inline helpers, but it's getting rather inconvenient.  I've
> > added a trivial helper to linux/highmem.h instead.
> 
> Yeah, "put_and_unmap_page()". Nice helper :-)

[snip]

Hi Al, 

> Why did you name it "put_and_unmap_page()" instead of 
"unmap_and_put_page()",
> for we always unmap first _and_ put the page immediately the unmapping?
>
> It seems it want to imply that instead we put first and unmap later (which
> would be wrong). That name sounds misleading to me and not sound (logically
> speaking).
> 
> Am I missing some obscure convention behind your choice of that name for the
> helper?

Can you please explain what I'm missing behind your motivation?

Thanks,

Fabio

P.S.: Adding Ira to the Cc list, since he's been doing kmap() and 
kmap_atomic() conversions long time before I too started with them.