linux-kernel - Re: [PATCH] driver core: class: fix documentation for class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h9RNMOQXQiquSj5qA_4m8sNHTHvjJR+OHkHg51AwSMRw@mail.gmail.com>
Date:   Mon, 27 Mar 2023 13:41:56 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] driver core: class: fix documentation for class_create()

On Mon, Mar 27, 2023 at 10:18 AM Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> In commit dcfbb67e48a2 ("driver core: class: use lock_class_key already
> present in struct subsys_private") we removed the key parameter to the
> function class_create() but forgot to remove it from the kerneldoc,
> which causes a build warning.  Fix that up by removing the key parameter
> from the documentation as it is now gone.
>
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Fixes: dcfbb67e48a2 ("driver core: class: use lock_class_key already present in struct subsys_private")
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Acked-by: Rafael J. Wysocki <rafael@...nel.org>

> ---
>  drivers/base/class.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/base/class.c b/drivers/base/class.c
> index dbaeb79ae917..0f8938a17144 100644
> --- a/drivers/base/class.c
> +++ b/drivers/base/class.c
> @@ -223,7 +223,6 @@ static void class_create_release(struct class *cls)
>  /**
>   * class_create - create a struct class structure
>   * @name: pointer to a string for the name of this class.
> - * @key: the lock_class_key for this class; used by mutex lock debugging
>   *
>   * This is used to create a struct class pointer that can then be used
>   * in calls to device_create().
> --
> 2.40.0
>