linux-kernel - Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCGCGb9E4KYlFNXR@duo.ucw.cz>
Date:   Mon, 27 Mar 2023 13:46:33 +0200
From:   Pavel Machek <pavel@....cz>
To:     ChiaEn Wu <chiaen_wu@...htek.com>
Cc:     corbet@....net, lee@...nel.org, matthias.bgg@...il.com,
        andriy.shevchenko@...ux.intel.com, jacek.anaszewski@...il.com,
        angelogioacchino.delregno@...labora.com, linux-doc@...r.kernel.org,
        peterwu.pub@...il.com, cy_huang@...htek.com,
        linux-leds@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        szunichen@...il.com, Alice Chen <alice_chen@...htek.com>
Subject: Re: [PATCH v18 1/3] leds: rgb: mt6370: Add MediaTek MT6370 current
 sink type LED Indicator support

Hi!

> The MediaTek MT6370 is a highly-integrated smart power management IC,
> which includes a single cell Li-Ion/Li-Polymer switching battery
> charger, a USB Type-C & Power Delivery (PD) controller, dual
> Flash LED current sources, a RGB LED driver, a backlight WLED driver,
> a display bias driver and a general LDO for portable devices.
> 
> Add support for the MediaTek MT6370 Current Sink Type LED Indicator
> driver. It can control four channels current-sink RGB LEDs with 3 modes:
> constant current, PWM, and breath mode.
> 
> Acked-by: Jacek Anaszewski <jacek.anaszewski@...il.com>
> Co-developed-by: Alice Chen <alice_chen@...htek.com>
> Signed-off-by: Alice Chen <alice_chen@...htek.com>
> Signed-off-by: ChiYuan Huang <cy_huang@...htek.com>
> Signed-off-by: ChiaEn Wu <chiaen_wu@...htek.com>


> +++ b/drivers/leds/rgb/Makefile
> @@ -2,3 +2,4 @@
>  
>  obj-$(CONFIG_LEDS_PWM_MULTICOLOR)	+= leds-pwm-multicolor.o
>  obj-$(CONFIG_LEDS_QCOM_LPG)		+= leds-qcom-lpg.o
> +obj-$(CONFIG_LEDS_MT6370_RGB)		+= leds-mt6370-rgb.o

I'd preffer leds-mt6370 name. We already have "rgb" in directory
name...

Otherwise looks good. Thanks for doing this.

BR,
								Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)