[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d6e483b15911a9be1e6c1d38200e50b5789738b2.camel@posteo.de>
Date: Mon, 27 Mar 2023 12:20:13 +0000
From: Martin Kepplinger <martink@...teo.de>
To: Wei Chen <harperchen1110@...il.com>
Cc: mchehab@...nel.org, linux-media@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] media: hi846: Fix memleak in hi846_init_controls()
Am Montag, dem 27.03.2023 um 11:58 +0000 schrieb Wei Chen:
> hi846_init_controls doesn't clean the allocated ctrl_hdlr
> in case there is a failure, which causes memleak. Add
> v4l2_ctrl_handler_free to free the resource properly.
>
> Fixes: e8c0882685f9 ("media: i2c: add driver for the SK Hynix Hi-846
> 8M pixel camera")
> Signed-off-by: Wei Chen <harperchen1110@...il.com>
just for the future: you don't need to send a new revision for tags-
addition only. That's usually something that maintainers can do when
applying, also (semi-)automated.
But *if* you send a new revision (due to other changes), you *should*
add all appropriate tags. So for this new revision you forgot this:
Reviewed-by: Martin Kepplinger <martin.kepplinger@...i.sm>
but, as you now know, you should not create a new revision for this
alone.
thanks,
martin
Powered by blists - more mailing lists