linux-kernel - Re: [PATCH] iio: tsl2772: remove unused prox_diode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 27 Mar 2023 16:07:48 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Tom Rix <trix@...hat.com>
Cc:     jic23@...nel.org, lars@...afoo.de, nathan@...nel.org,
        ndesaulniers@...gle.com, u.kleine-koenig@...gutronix.de,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        llvm@...ts.linux.dev
Subject: Re: [PATCH] iio: tsl2772: remove unused prox_diode_mask variable

On Mon, Mar 27, 2023 at 08:08:23AM -0400, Tom Rix wrote:
> clang with W=1 reports
> drivers/iio/light/tsl2772.c:576:24: error: variable
>   'prox_diode_mask' set but not used [-Werror,-Wunused-but-set-variable]
>         int i, ret, num_leds, prox_diode_mask;
>                               ^
> This variable is not used so remove it.

While from the compilation point of view this is a correct fix, I think
we need to hear from the author (or interested stakeholders) about this
feature. Perhaps it should be enabled / fixed differently.

-- 
With Best Regards,
Andy Shevchenko