linux-kernel - Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2023 16:19:13 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Pankaj Raghav <p.raghav@...sung.com>
Cc:     martin@...ibond.com, axboe@...nel.dk, minchan@...nel.org,
        akpm@...ux-foundation.org, hubcap@...ibond.com,
        viro@...iv.linux.org.uk, senozhatsky@...omium.org,
        brauner@...nel.org, linux-kernel@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, mcgrof@...nel.org,
        linux-block@...r.kernel.org, gost.dev@...sung.com,
        linux-mm@...ck.org, devel@...ts.orangefs.org
Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio
 end_io handler

On Tue, Mar 28, 2023 at 01:27:12PM +0200, Pankaj Raghav wrote:
> -static void zram_page_end_io(struct bio *bio)
> +static void zram_read_end_io(struct bio *bio)
>  {
> -	struct page *page = bio_first_page_all(bio);
> -
> -	page_endio(page, op_is_write(bio_op(bio)),
> -			blk_status_to_errno(bio->bi_status));
>  	bio_put(bio);
>  }
>  
> @@ -635,7 +631,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
>  	}
>  
>  	if (!parent)
> -		bio->bi_end_io = zram_page_end_io;
> +		bio->bi_end_io = zram_read_end_io;

Can we just do:

	if (!parent)
		bio->bi_end_io = bio_put;

drivers/nvme/target/passthru.c does this, so it wouldn't be the first.