linux-kernel - Re: [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5017f565-1047-6f0c-e578-e8ed9d31802f@deltatee.com>
Date:   Tue, 28 Mar 2023 11:36:14 -0600
From:   Logan Gunthorpe <logang@...tatee.com>
To:     Bjorn Helgaas <helgaas@...nel.org>,
        Cai Huoqing <cai.huoqing@...ux.dev>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>, linux-pci@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] PCI/P2PDMA: Fix the comments on pci_p2pmem_find_many()



On 2023-03-28 11:34, Bjorn Helgaas wrote:
> On Tue, Mar 28, 2023 at 07:06:10PM +0800, Cai Huoqing wrote:
>> Remove pci_p2pmem_dma() reference,
>> because pci_p2pmem_dma() method is already removed.
> 
> AFAICT, pci_p2pmem_dma() *never* existed.  I suppose it was a typo,
> and pci_p2pdma_distance_many() was intended?
> 
> I'm happy to either merge this patch (with an updated commit log) to
> remove the comment text or merge a patch correct the comment text.
> 
> I just don't want to merge this with a commit log that says we removed
> the pci_p2pmem_dma() method when it never actually existed.

Ah, yes that's fair. I thought pci_p2pmem_dma() was an odd function
name. Good to confirm it never existed.

Thanks,

Logan