linux-kernel - Re: [PATCH v3 1/4] staging: rtl8192u: remove change history from comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 28 Mar 2023 10:17:21 +0700
From:   Bagas Sanjaya <bagasdotme@...il.com>
To:     Khadija Kamran <kamrankhadijadj@...il.com>,
        outreachy@...ts.linux.dev
Cc:     gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org,
        Jerry Chuang <jerry-chuang@...ltek.com>
Subject: Re: [PATCH v3 1/4] staging: rtl8192u: remove change history from
 comments

On Tue, Mar 28, 2023 at 12:49:06AM +0500, Khadija Kamran wrote:
> Remove the change history information as it is not required in the
> comments.

(also Cc: original driver author)

What about below?

```
Remove obsolete change history info as developers can simply use git to
browse commit history of the driver.
```

> 
> Signed-off-by: Khadija Kamran <kamrankhadijadj@...il.com>
> ---
>  drivers/staging/rtl8192u/r8192U_dm.c | 45 ----------------------------
>  1 file changed, 45 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/r8192U_dm.c b/drivers/staging/rtl8192u/r8192U_dm.c
> index 6a33ca02c3dc..b1ebb776fc42 100644
> --- a/drivers/staging/rtl8192u/r8192U_dm.c
> +++ b/drivers/staging/rtl8192u/r8192U_dm.c
> @@ -7,12 +7,6 @@ Module Name:
>  
>  Abstract:
>  	HW dynamic mechanism.
> -
> -Major Change History:
> -	When		Who				What
> -	----------	--------------- -------------------------------
> -	2008-05-14	amy                     create version 0 porting from windows code.
> -
>  --*/
>  #include "r8192U.h"
>  #include "r8192U_dm.h"
> @@ -274,11 +268,6 @@ void init_rate_adaptive(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	05/26/08	amy	Create version 0 porting from windows code.
> - *
>   *---------------------------------------------------------------------------*/
>  static void dm_check_rate_adaptive(struct net_device *dev)
>  {
> @@ -1589,11 +1578,6 @@ static void dm_bb_initialgain_backup(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	05/15/2008	amy		Create Version 0 porting from windows code.
> - *
>   *---------------------------------------------------------------------------*/
>  static void dm_dig_init(struct net_device *dev)
>  {
> @@ -1634,10 +1618,6 @@ static void dm_dig_init(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	05/27/2008	amy		Create Version 0 porting from windows code.
>   *---------------------------------------------------------------------------*/
>  static void dm_ctrl_initgain_byrssi(struct net_device *dev)
>  {
> @@ -1850,11 +1830,6 @@ static void dm_ctrl_initgain_byrssi_by_fwfalse_alarm(
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	05/28/2008	amy		Create Version 0 porting from windows code.
> - *
>   *---------------------------------------------------------------------------*/
>  static void dm_ctrl_initgain_byrssi_highpwr(
>  	struct net_device *dev)
> @@ -2269,11 +2244,6 @@ static void dm_ctstoself(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	05/28/2008	amy	Create Version 0 porting from windows code.
> - *
>   *---------------------------------------------------------------------------*/
>  static	void	dm_check_pbc_gpio(struct net_device *dev)
>  {
> @@ -2303,11 +2273,6 @@ static	void	dm_check_pbc_gpio(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	01/30/2008	MHC		Create Version 0.
> - *
>   *---------------------------------------------------------------------------*/
>  void dm_rf_pathcheck_workitemcallback(struct work_struct *work)
>  {
> @@ -2552,11 +2517,6 @@ static void dm_rxpath_sel_byrssi(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	05/28/2008	amy		Create Version 0 porting from windows code.
> - *
>   *---------------------------------------------------------------------------*/
>  static void dm_check_rx_path_selection(struct net_device *dev)
>  {
> @@ -2871,11 +2831,6 @@ void dm_check_fsync(struct net_device *dev)
>   * Output:		NONE
>   *
>   * Return:		NONE
> - *
> - * Revised History:
> - *	When		Who		Remark
> - *	03/06/2008	Jacken	Create Version 0.
> - *
>   *---------------------------------------------------------------------------
>   */
>  static void dm_init_dynamic_txpower(struct net_device *dev)

The rest is LGTM, thanks!

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)