linux-kernel - Re: [PATCH] kunit: increase KUNIT_LOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+GJov6YeJA5Hed=sLOdDY43WkwVrQ9i1dPsQ_inVdDhpBjUug@mail.gmail.com>
Date:   Tue, 28 Mar 2023 14:30:22 -0400
From:   Rae Moar <rmoar@...gle.com>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     Brendan Higgins <brendan.higgins@...ux.dev>,
        David Gow <davidgow@...gle.com>,
        Shuah Khan <skhan@...uxfoundation.org>,
        Alexander Egorenkov <egorenar@...ux.ibm.com>,
        Vasily Gorbik <gor@...ux.ibm.com>,
        linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kunit: increase KUNIT_LOG_SIZE to 2048 bytes

On Mon, Mar 27, 2023 at 7:53 AM Heiko Carstens <hca@...ux.ibm.com> wrote:
>
> The s390 specific test_unwind kunit test has 39 parameterized tests. The
> results in debugfs are truncated since the full log doesn't fit into 1500
> bytes.
> Therefore increase KUNIT_LOG_SIZE to 2048 bytes in a similar way like it
> was done recently with commit "kunit: fix bug in debugfs logs of
> parameterized tests". With that the whole test result is present.
>
> Reported-by: Alexander Egorenkov <egorenar@...ux.ibm.com>
> Signed-off-by: Heiko Carstens <hca@...ux.ibm.com>
> ---

This looks good to me. I don't see an issue increasing the log size.
Maybe eventually we could create a config option or test attribute for
a large log size but for now this seems good. Glad to see people are
starting to get use of the parameterized test logs after the debugfs
fixes.

Thanks!
-Rae

Reviewed-by: Rae Moar <rmoar@...gle.com>

>  include/kunit/test.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/kunit/test.h b/include/kunit/test.h
> index 9721584027d8..57b309c6ca27 100644
> --- a/include/kunit/test.h
> +++ b/include/kunit/test.h
> @@ -34,7 +34,7 @@ DECLARE_STATIC_KEY_FALSE(kunit_running);
>  struct kunit;
>
>  /* Size of log associated with test. */
> -#define KUNIT_LOG_SIZE 1500
> +#define KUNIT_LOG_SIZE 2048
>
>  /* Maximum size of parameter description string. */
>  #define KUNIT_PARAM_DESC_SIZE 128
> --
> 2.37.2
>