linux-kernel - Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZCM/bUZqQ+hbvZrG@probook>
Date:   Tue, 28 Mar 2023 21:26:37 +0200
From:   Jonathan Neuschäfer <j.neuschaefer@....net>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Jonathan Neuschäfer <j.neuschaefer@....net>,
        linux-edac@...r.kernel.org, Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Robert Richter <rric@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/amd81*1: Remove "\n" from MODULE_AUTHOR

On Sun, Mar 19, 2023 at 08:20:11PM +0100, Borislav Petkov wrote:
> On Sun, Jan 29, 2023 at 05:50:54PM +0100, Jonathan Neuschäfer wrote:
[...]
> Wanna fix the other two in the EDAC tree:
> 
> drivers/edac/e752x_edac.c:1465:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Tom Zimmerman\n");
> drivers/edac/e7xxx_edac.c:599:MODULE_AUTHOR("Linux Networx (http://lnxi.com) Thayne Harbaugh et al\n"
> 
> ?
> 
> That macro takes:
> 
> /*
>  * Author(s), use "Name <email>" or just "Name", for multiple
>  * authors use multiple MODULE_AUTHOR() statements/lines.
>  */
> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
> 
> and not prose.
> 
> You can move the prose to the top comment in the respective file, if it
> doesn't contain it yet.
> 
> Thx.

Sorry for the late reply. I'm replying now because I saw that you
applied the patch.

I might fix the above if/when I get around to it, but there's currently
no guarantee of that.


Best regards,
Jonathan

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)