linux-kernel - Re: [PATCH] fsverity: use WARN_ON_ONCE instead of WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <962dab64-8010-26b5-a8d9-872fc27dce3e@nvidia.com>
Date:   Tue, 28 Mar 2023 06:15:59 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Eric Biggers <ebiggers@...nel.org>,
        "fsverity@...ts.linux.dev" <fsverity@...ts.linux.dev>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fsverity: use WARN_ON_ONCE instead of WARN_ON

On 3/27/23 21:03, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@...gle.com>
>
> As per Linus's suggestion
> (https://lore.kernel.org/r/CAHk-=whefxRGyNGzCzG6BVeM=5vnvgb-XhSeFJVxJyAxAF8XRA@mail.gmail.com),
> use WARN_ON_ONCE instead of WARN_ON.  This barely adds any extra
> overhead, and it makes it so that if any of these ever becomes reachable
> (they shouldn't, but that's the point), the logs can't be flooded.
>
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>
> ---
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck