linux-kernel - Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq SoC dt bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4fcb67bf-aa12-61c3-ca30-3fb11eaba67a@linaro.org>
Date:   Tue, 28 Mar 2023 08:32:21 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Aleksander Bajkowski <olek2@...pl>, tsbogend@...ha.franken.de,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        linux-mips@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: mips: lantiq: Document Lantiq SoC dt
 bindings

On 27/03/2023 23:21, Aleksander Bajkowski wrote:
>>> +properties:
>>> +  $nodename:
>>> +    const: "/"
>>> +  compatible:
>>> +    oneOf:
>>> +      - description: Boards with Lantiq Amazon-SE SoC
>>> +        items:
>>> +          - const: lantiq,ase
>> This does not look like proper board compatible. Boards have almost
>> always minimum two compatibles - one for SoC and one for board. With
>> commit msg this just adds to confusion...
>>
> 
> The added dt-binding contains only the SoC part. The compatible strings
> for individual boards will be added later together with the dts files. Before
> sending the dts files I want to document current bindings and clear
> checkpach warnings about undocumented strings.

Which is incomplete and inaccurate documentation. Instead, document
proper, full compatibles.

Best regards,
Krzysztof