linux-kernel - Re: [PATCH v3] remoteproc: remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4b64c2ed-b3a3-46fc-b5c7-3c03b30cd8a2@kili.mountain>
Date:   Tue, 28 Mar 2023 10:40:04 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Yu Zhe <yuzhe@...china.com>
Cc:     andersson@...nel.org, mathieu.poirier@...aro.org,
        matthias.bgg@...il.com, angelogioacchino.delregno@...labora.com,
        agross@...nel.org, konrad.dybcio@...aro.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...s.st.com,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        kernel-janitors@...r.kernel.org, liqiong@...china.com
Subject: Re: [PATCH v3] remoteproc: remove unnecessary (void*) conversions

On Tue, Mar 28, 2023 at 09:57:49AM +0800, Yu Zhe wrote:
>  static void devm_rproc_free(struct device *dev, void *res)
>  {
> -	rproc_free(*(struct rproc **)res);
> +	rproc_free(res);

This introduces a bug.

regards,
dan carpenter