[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <ZCKds6_2QYrZgMXh@kroah.com>
Date: Tue, 28 Mar 2023 09:56:35 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Daniel Watson <ozzloy@...il.com>
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: move open curly to first line of if
On Tue, Mar 28, 2023 at 12:34:29AM -0700, Daniel Watson wrote:
> Checkpatch flagged this as a fixable style error.
What exactly is "this"?
Take a look at the kernel documentation, specifically the file,
Documentation/process/submitting-patches.rst in the section entitled,
"The canonical patch format", for how to write a good subject line, and
changelog text.
Most of the time, that's the hardest part of writing a patch.
Fix that up and send a v2 please (after reading in that same file for
how to properly document that this is a version 2...)
thanks,
greg k-h
Powered by blists - more mailing lists