linux-kernel - Re: [PATCH 1/5] objtool: Add '--verbose' option for disassembling affected functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.21.2303281046470.14873@pobox.suse.cz>
Date:   Tue, 28 Mar 2023 10:47:26 +0200 (CEST)
From:   Miroslav Benes <mbenes@...e.cz>
To:     Josh Poimboeuf <jpoimboe@...nel.org>
cc:     x86@...nel.org, linux-kernel@...r.kernel.org,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 1/5] objtool: Add '--verbose' option for disassembling
 affected functions

> +static inline void objdump_func(struct section *sec, unsigned long offset)
> +{
> +	struct symbol *sym = find_func_containing(sec, offset);

Unnecessary assignment?

> +	const char *script_relative = "scripts/objdump-func";
> +	bool is_text = (sec->sh.sh_flags & SHF_EXECINSTR);
> +	char *cmd, *srctree, *script;
> +
> +	if (is_text)
> +		sym = find_func_containing(sec, offset);
> +	if (!sym)
> +		sym = find_symbol_containing(sec, offset);
> +	if (!sym)
> +		return;

Miroslav