linux-kernel - Re: [PATCH -next] devfreq: exynos-ppmu: Use devm_platform_get_and_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230328095337.sr6s3klmhiyz63pr@intel.intel>
Date:   Tue, 28 Mar 2023 11:53:37 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Yang Li <yang.lee@...ux.alibaba.com>, kyungmin.park@...sung.com,
        myungjoo.ham@...sung.com, cw00.choi@...sung.com,
        alim.akhtar@...sung.com, linux-pm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] devfreq: exynos-ppmu: Use
 devm_platform_get_and_ioremap_resource()

Hi,

On Tue, Mar 28, 2023 at 09:19:01AM +0200, Krzysztof Kozlowski wrote:
> On 28/03/2023 07:38, Yang Li wrote:
> > According to commit 890cc39a8799 ("drivers: provide
> > devm_platform_get_and_ioremap_resource()"), convert
> 
> I don't understand why do you reference this commit. There is no bug
> introduced there, there is nothing related to this driver.
> 
> > platform_get_resource(), devm_ioremap_resource() to a single
> > call to devm_platform_get_and_ioremap_resource(), as this is exactly
> > what this function does.

I've seen Yang has sent many of these cleanups, perhaps he can
write something like:

"
Commit 890cc39a8799 ("drivers: provide
devm_platform_get_and_ioremap_resource()") introduces the
devm_platform_get_and_ioremap_resource() function which combines
both platform_get_resource() and devm_ioremap_resource() into a
single call.

Update the code to use the new combined function instead of the
separate calls.
"

With that

Reviewed-by: Andi Shyti <andi.shyti@...nel.org>

Thanks,
Andi