linux-kernel - Re: [PATCH 00/12] drm/amd: Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878rfh5gg3.fsf@intel.com>
Date:   Tue, 28 Mar 2023 13:16:28 +0300
From:   Jani Nikula <jani.nikula@...ux.intel.com>
To:     Caio Novais <caionovais@....br>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     Felipe Clark <felipe.clark@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        Maíra Canal <mairacanal@...eup.net>,
        Mario Limonciello <mario.limonciello@....com>,
        Jun Lei <Jun.Lei@....com>, Charlene Liu <Charlene.Liu@....com>,
        Gabe Teeger <gabe.teeger@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Taimur Hassan <Syed.Hassan@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Alvin Lee <alvin.lee2@....com>,
        George Shen <George.Shen@....com>,
        Hamza Mahfooz <hamza.mahfooz@....com>,
        Chaitanya Dhere <chaitanya.dhere@....com>,
        Alan Liu <HaoPing.Liu@....com>,
        Mukul Joshi <mukul.joshi@....com>,
        André Almeida 
        <andrealmeid@...lia.com>, Jingwen Zhu <Jingwen.Zhu@....com>,
        Guo Zhengkui <guozhengkui@...o.com>,
        Leo Li <sunpeng.li@....com>, Melissa Wen <mwen@...lia.com>,
        Le Ma <le.ma@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Caio Novais <caionovais@....br>,
        Martin Leung <Martin.Leung@....com>,
        Ryan Lin <tsung-hua.lin@....com>,
        Brian Chang <Brian.Chang@....com>,
        Sung Joon Kim <sungjoon.kim@....com>,
        Yifan Zhang <yifan1.zhang@....com>,
        Jack Xiao <Jack.Xiao@....com>,
        Dillon Varone <Dillon.Varone@....com>,
        Tom Chung <chiahsuan.chung@....com>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>, Zhan Liu <zhan.liu@....com>,
        Roman Li <Roman.Li@....com>,
        Christian König <christian.koenig@....com>,
        Wayne Lin <wayne.lin@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Ethan Wellenreiter <Ethan.Wellenreiter@....com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Joshua Ashton <joshua@...ggi.es>,
        Hawking Zhang <Hawking.Zhang@....com>
Subject: Re: [PATCH 00/12] drm/amd: Remove unused variables

On Mon, 27 Mar 2023, Caio Novais <caionovais@....br> wrote:
> This patchset cleans the code removing unused variables and one unused
> function.
>
> Caio Novais (12):
>   Remove unused variable 'r'
>   Remove unused variable 'value0'
>   Remove unused variable 'pixel_width'
>   Remove unused variable 'hubp'
>   Remove unused variable 'speakers'
>   Remove unused variable 'mc_vm_apt_default'
>   Remove unused variable 'optc'
>   Remove two unused variables 'speakers' and 'channels' and remove
>     unused function 'speakers_to_channels'
>   Remove two unused variables 'is_pipe_split_expected' and 'state'
>   Remove unused variable 'cursor_bpp'
>   Remove unused variable 'scl_enable'
>   Remove two unused variables 'result_write_min_hblank' and
>     'hblank_size'

Curious, how did you create this? It does not match the patches.

BR,
Jani.

>
>  drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c       |  8 ----
>  .../amd/display/dc/dcn10/dcn10_link_encoder.c |  3 --
>  .../drm/amd/display/dc/dcn201/dcn201_dpp.c    |  6 ---
>  .../drm/amd/display/dc/dcn201/dcn201_hwseq.c  |  2 -
>  .../gpu/drm/amd/display/dc/dcn30/dcn30_afmt.c |  2 -
>  .../gpu/drm/amd/display/dc/dcn30/dcn30_hubp.c |  4 --
>  .../drm/amd/display/dc/dcn30/dcn30_hwseq.c    |  3 --
>  .../gpu/drm/amd/display/dc/dcn31/dcn31_apg.c  | 39 -------------------
>  .../drm/amd/display/dc/dcn32/dcn32_resource.c |  4 --
>  .../display/dc/dcn32/dcn32_resource_helpers.c |  4 --
>  .../dc/dml/dcn31/display_rq_dlg_calc_31.c     |  2 -
>  .../dc/link/protocols/link_dp_capability.c    |  7 ----
>  12 files changed, 84 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center