linux-kernel - Re: [PATCH] LoongArch: Add kernel address sanitizer support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9817aaa043e9f0ed964bd523773447bd64f6e2c0.camel@xry111.site>
Date:   Tue, 28 Mar 2023 19:39:42 +0800
From:   Xi Ruoyao <xry111@...111.site>
To:     Qing Zhang <zhangqing@...ngson.cn>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Huacai Chen <chenhuacai@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Vincenzo Frascino <vincenzo.frascino@....com>,
        WANG Xuerui <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        kasan-dev@...glegroups.com, linux-doc@...r.kernel.org,
        linux-mm@...ck.org, loongarch@...ts.linux.dev,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] LoongArch: Add kernel address sanitizer support

On Tue, 2023-03-28 at 19:17 +0800, Qing Zhang wrote:

/* snip */


> -void * __init relocate_kernel(void)
> +unsigned long __init relocate_kernel(void)

Why we must modify relocate_kernel for KASAN?

>  {
>         unsigned long kernel_length;
>         unsigned long random_offset = 0;
>         void *location_new = _text; /* Default to original kernel start */
> -       void *kernel_entry = start_kernel; /* Default to original kernel entry point */
>         char *cmdline = early_ioremap(fw_arg1, COMMAND_LINE_SIZE); /* Boot command line is passed in fw_arg1 */
>  
>         strscpy(boot_command_line, cmdline, COMMAND_LINE_SIZE);
> @@ -190,9 +189,6 @@ void * __init relocate_kernel(void)
>  
>                 reloc_offset += random_offset;
>  
> -               /* Return the new kernel's entry point */
> -               kernel_entry = RELOCATED_KASLR(start_kernel);
> -
>                 /* The current thread is now within the relocated kernel */
>                 __current_thread_info = RELOCATED_KASLR(__current_thread_info);
>  
> @@ -204,7 +200,7 @@ void * __init relocate_kernel(void)
>  
>         relocate_absolute(random_offset);
>  
> -       return kernel_entry;
> +       return random_offset;

-- 
Xi Ruoyao <xry111@...111.site>
School of Aerospace Science and Technology, Xidian University