| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <253f3bf2-a193-69da-79ef-c3771d677478@loongson.cn>
Date: Tue, 28 Mar 2023 19:53:34 +0800
From: zhuyinbo <zhuyinbo@...ngson.cn>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-spi@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, Jianmin Lv <lvjianmin@...ngson.cn>,
wanghongliang@...ngson.cn, Liu Peibao <liupeibao@...ngson.cn>,
loongson-kernel@...ts.loongnix.cn, zhuyinbo@...ngson.cn
Subject: Re: [PATCH v4 0/2] spi: loongson: add bus driver for the loongson spi
在 2023/3/28 下午7:35, Andi Shyti 写道:
> Hi Yinbo,
>
> before submitting the patches for review... can you please run
> checkpatch.pl on them?
yes, I had used checkpatch.pl to check and no any errors and warnings.
user@...r-pc:~/workspace/test/code/www.kernel.org/linux$
./scripts/checkpatch.pl *.patch
-----------------------
0000-cover-letter.patch
-----------------------
total: 0 errors, 0 warnings, 0 lines checked
0000-cover-letter.patch has no obvious style problems and is ready for
submission.
-------------------------------------------
0001-dt-bindings-spi-add-loongson-spi.patch
-------------------------------------------
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
total: 0 errors, 0 warnings, 55 lines checked
0001-dt-bindings-spi-add-loongson-spi.patch has no obvious style
problems and is ready for submission.
---------------------------------------------------------------
0002-spi-loongson-add-bus-driver-for-the-loongson-spi-con.patch
---------------------------------------------------------------
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
Traceback (most recent call last):
File "scripts/spdxcheck.py", line 6, in <module>
from ply import lex, yacc
ModuleNotFoundError: No module named 'ply'
total: 0 errors, 0 warnings, 556 lines checked
0002-spi-loongson-add-bus-driver-for-the-loongson-spi-con.patch has no
obvious style problems and is ready for submission.
user@...r-pc:~/workspace/test/code/www.kernel.org/linux$
>
> Thanks,
> Andi
>
> On Tue, Mar 28, 2023 at 07:22:08PM +0800, Yinbo Zhu wrote:
>> Loongson platform support spi hardware controller and this series patch
>> was to add spi driver and binding support.
>>
>> Change in v2:
>> 1. This [PATCH v2 1/2] dt-bindings patch need depend on clk patch:
>> https://
>> lore.kernel.org/all/20230307115022.12846-1-zhuyinbo@...ngson.cn/
>> 2. Remove the clock-names in spi yaml file.
>> 3. Add "loongson,ls7a-spi" compatible in spi yaml file.
>> 4. Add an || COMPILE_TEST and drop && PCI then add some CONFIG_PCI
>> macro to limit some pci code.
>> 5. Make the spi driver top code comment block that use C++ style.
>> 6. Drop spi->max_speed_hz.
>> 7. Add a spin_lock for loongson_spi_setup.
>> 8. Add a timeout and cpu_relax() in loongson_spi_write_read_8bit.
>> 9. Add spi_transfer_one and drop transfer and rework entire spi
>> driver that include some necessary changes.
>> 10. Use module_init replace subsys_initcall.
>> 11. About PM interface that I don't find any issue so I don't add
>> any changes.
>> Change in v3:
>> 1. This [PATCH v3 1/2] dt-bindings patch need depend on clk patch:
>> https://
>> lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@...ngson.cn/
>> 2. Drop the unused blank line in loongson,ls-spi.yaml file.
>> 3. Replace clock minItems with clock maxItems in yaml file.
>> 4. Separate spi driver into platform module, pci module and core
>> module.
>> 5. Replace DIV_ROUND_UP with DIV_ROUND_UP_ULL to fix compile error
>> "undefined reference to `__aeabi_uldivmod'" and "__udivdi3 undefined"
>> that reported by test robot.
>> 6. Remove the spin lock.
>> 7. Clear the loongson_spi->hz and loongson_spi->mode in setup to fixup
>> the issue that multiple spi device transfer that maybe cause spi was
>> be misconfigured.
>> Change in v4:
>> 1. This [PATCH v4 1/2] dt-bindings patch need depend on clk patch:
>> https://
>> lore.kernel.org/all/20230323025229.2971-1-zhuyinbo@...ngson.cn/
>> 2. Add "#include <linux/io.h>" in spi-loongson-core.c for fix the compile
>> issue which devm_ioremap no declaration.
>> 3. Add "EXPORT_SYMBOL_GPL(loongson_spi_dev_pm_ops)" in
>> spi-loongson-core.c for fix the compile issue which
>> loongson_spi_dev_pm_ops undefined.
>>
>> Yinbo Zhu (2):
>> dt-bindings: spi: add loongson spi
>> spi: loongson: add bus driver for the loongson spi controller
>>
>> .../bindings/spi/loongson,ls-spi.yaml | 43 +++
>> MAINTAINERS | 10 +
>> drivers/spi/Kconfig | 31 ++
>> drivers/spi/Makefile | 3 +
>> drivers/spi/spi-loongson-core.c | 304 ++++++++++++++++++
>> drivers/spi/spi-loongson-pci.c | 89 +++++
>> drivers/spi/spi-loongson-plat.c | 66 ++++
>> drivers/spi/spi-loongson.h | 41 +++
>> 8 files changed, 587 insertions(+)
>>
>> --
>> 2.20.1
>>
Powered by blists - more mailing lists