linux-kernel - Re: [PATCH] mtdblock: tolerate corrected bit-flips

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230328160027.21b5b340@xps-13>
Date:   Tue, 28 Mar 2023 16:00:27 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Richard Weinberger <richard@....at>
Cc:     Bang Li <libang.linuxer@...il.com>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd <linux-mtd@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtdblock: tolerate corrected bit-flips

Hi Richard,

richard@....at wrote on Tue, 28 Mar 2023 15:21:50 +0200 (CEST):

> Hi!
> 
> ----- Ursprüngliche Mail -----
> > libang.linuxer@...il.com wrote on Thu, 23 Mar 2023 22:03:50 +0800:
> >   
> >> mtd_read() may return -EUCLEAN in case of corrected bit-flips.This
> >> particular condition should not be treated like an error.  
> > 
> > I'm fine with the patch, Richard, are you okay as well?  
> 
> Hm yes. I see the bug. I think it broke about 10 years ago
> by e47f68587b82 ("mtd: check for max_bitflips in mtd_read_oob()").
> 
> In the early day I'd expect someone to hit this bug but I guess
> on the last 10 years mtdblock had no real users.

Right.

Well, anyhow I guess this patch deserves a Fixes/Cc: stable # v3.7+

Li, can you please re-send with the proper tags? Thanks.

Thanks,
Miquèl