linux-kernel - Re: [PATCH] scsi: iscsi_tcp: Check the sock is correct before iscsi_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <15e892ef-0ab4-b2c9-bfc7-6cc3ba221c4a@oracle.com>
Date:   Wed, 29 Mar 2023 10:17:07 -0500
From:   Mike Christie <michael.christie@...cle.com>
To:     Zhong Jinghua <zhongjinghua@...weicloud.com>, lduncan@...e.com,
        cleech@...hat.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com
Cc:     open-iscsi@...glegroups.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, zhongjinghua@...wei.com,
        yi.zhang@...wei.com, yukuai3@...wei.com, houtao1@...wei.com
Subject: Re: [PATCH] scsi: iscsi_tcp: Check the sock is correct before
 iscsi_set_param

On 3/29/23 2:17 AM, Zhong Jinghua wrote:
> From: Zhong Jinghua <zhongjinghua@...wei.com>
> 
> The correctness of sock should be checked before assignment to avoid
> assigning wrong values.
> 
> Commit
> "scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()"
> introduced this change. This change may lead to inconsistent values of
> tcp_sw_conn->sendpage and conn->datadgst_en.
> 
> Fix it by moving the position of the assignment.
> 
> Fixes: 57569c37f0ad ("scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()")
> Signed-off-by: Zhong Jinghua <zhongjinghua@...wei.com>

Thanks.

Reviewed-by: Mike Christie <michael.christie@...cle.com>