linux-kernel - Re: [PATCH -next v3] ubi: Fix failure attaching when vid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230329175421.3bd4906e@xps-13>
Date:   Wed, 29 Mar 2023 17:54:21 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Zhihao Cheng <chengzhihao1@...wei.com>
Cc:     Nicolas Schichan <nschichan@...ebox.fr>,
        <george.kennedy@...cle.com>, <linux-kernel@...r.kernel.org>,
        <linux-mtd@...ts.infradead.org>, <richard@....at>,
        <s.hauer@...gutronix.de>, <yi.zhang@...wei.com>
Subject: Re: [PATCH -next v3] ubi: Fix failure attaching when vid_hdr offset
 equals to (sub)page size

Hello,

chengzhihao1@...wei.com wrote on Sat, 25 Mar 2023 09:02:40 +0800:

> Hi,
> >   
> >> Following process will make ubi attaching failed since commit
> >> 1b42b1a36fc946 ("ubi: ensure that VID header offset ... size"):
> >>
> >> ID="0xec,0xa1,0x00,0x15" # 128M 128KB 2KB
> >> modprobe nandsim id_bytes=$ID
> >> flash_eraseall /dev/mtd0
> >> modprobe ubi mtd="0,2048"  # set vid_hdr offset as 2048 (one page)
> >> (dmesg):
> >>    ubi0 error: ubi_attach_mtd_dev [ubi]: VID header offset 2048 too large.
> >>    UBI error: cannot attach mtd0
> >>    UBI error: cannot initialize UBI, error -22
> >>
> >> Rework original solution, the key point is making sure
> >> 'vid_hdr_shift + UBI_VID_HDR_SIZE < ubi->vid_hdr_alsize',
> >> so we should check vid_hdr_shift rather not vid_hdr_offset.
> >> Then, ubi still support (sub)page aligined VID header offset.

					aligned

> >>
> >> Fixes: 1b42b1a36fc946 ("ubi: ensure that VID header offset ... size")

This commit has been backported to stable, so it is important this fix
also gets there quickly:

Cc: stable@...r.kernel.org

> >> Signed-off-by: Zhihao Cheng <chengzhihao1@...wei.com>
> >> ---
> >>   v2->v3: Use printing format '%zu' for UBI_VID_HDR_SIZE.
> >>   drivers/mtd/ubi/build.c | 21 +++++++++++++++------
> >>   1 file changed, 15 insertions(+), 6 deletions(-)  
> > 
> > [...]
> > 
> > Hello,
> > 
> > Having had the problem, and found this patch as a fix, feel free to
> > add my:
> >   
> 
> Thanks for testing.
> 
> > Tested-by: Nicolas Schichan <nschichan@...ebox.fr>

Same here.

Tested-by: Miquel Raynal <miquel.raynal@...tlin.com> # v5.10, v4.19

Thanks,
Miquèl