linux-kernel - Re: [PATCH 2/2] drm/amd/display: Add previous prototype to 'optc3_wait_drr_doublebuffer_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fba14fea-787b-c5b2-a72a-ab802f76b3f7@amd.com>
Date:   Wed, 29 Mar 2023 12:07:56 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Caio Novais <caionovais@....br>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        "Lee, Alvin" <Alvin.Lee2@....com>, Jun Lei <Jun.Lei@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Gabe Teeger <gabe.teeger@....com>, Roman Li <roman.li@....com>,
        Maíra Canal <mairacanal@...eup.net>,
        Deepak R Varma <drv@...lo.com>
Subject: Re: [PATCH 2/2] drm/amd/display: Add previous prototype to
 'optc3_wait_drr_doublebuffer_pending_clear'


On 3/28/23 18:09, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
> 
> Get rid of it by adding a function prototype
> 
> 'optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)' on drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> 
> Signed-off-by: Caio Novais <caionovais@....br>
> ---
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> index fb06dc9a4893..2e3ba6e2f336 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.h
> @@ -331,6 +331,8 @@ void optc3_lock_doublebuffer_enable(struct timing_generator *optc);
>   
>   void optc3_lock_doublebuffer_disable(struct timing_generator *optc);
>   
> +void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc);

I would prefer if you marked the function as static instead, since it is
only used in dcn30_optc.c.

> +
>   void optc3_set_drr_trigger_window(struct timing_generator *optc,
>   		uint32_t window_start, uint32_t window_end);
>   

-- 
Hamza