linux-kernel - Re: [PATCH] thermal: intel: int340x: processor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0iz6HAG+bhGb0HHmjwANdGmziJLHzH4XEz_CK7R1MexWQ@mail.gmail.com>
Date:   Wed, 29 Mar 2023 20:37:55 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
Cc:     rafael@...nel.org, rui.zhang@...el.com, daniel.lezcano@...aro.org,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] thermal: intel: int340x: processor_thermal: Fix
 additional deadlock

On Wed, Mar 29, 2023 at 5:23 PM Srinivas Pandruvada
<srinivas.pandruvada@...ux.intel.com> wrote:
>
> Commit 52f04f10b900 ("thermal: intel: int340x: processor_thermal: Fix
> deadlock") addressed deadlock issue during user space trip update. But it
> missed a case when thermal zone device is disabled when user writes 0.
>
> Call to thermal_zone_device_disable() also causes deadlock as it also
> tries to lock tz->lock, which is already claimed by trip_point_temp_store()
> in the thermal core code.
>
> Remove call to thermal_zone_device_disable() in the function
> sys_set_trip_temp(), which is called from trip_point_temp_store().
>
> Fixes: 52f04f10b900 ("thermal: intel: int340x: processor_thermal: Fix deadlock")
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: stable@...r.kernel.org # 6.2+
> ---
>  .../thermal/intel/int340x_thermal/processor_thermal_device_pci.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
> index 90526f46c9b1..d71ee50e7878 100644
> --- a/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
> +++ b/drivers/thermal/intel/int340x_thermal/processor_thermal_device_pci.c
> @@ -153,7 +153,6 @@ static int sys_set_trip_temp(struct thermal_zone_device *tzd, int trip, int temp
>                 cancel_delayed_work_sync(&pci_info->work);
>                 proc_thermal_mmio_write(pci_info, PROC_THERMAL_MMIO_INT_ENABLE_0, 0);
>                 proc_thermal_mmio_write(pci_info, PROC_THERMAL_MMIO_THRES_0, 0);
> -               thermal_zone_device_disable(tzd);
>                 pci_info->stored_thres = 0;
>                 return 0;
>         }
> --

Applied as 6.3-rc material, thanks!