linux-kernel - Re: [PATCH] clk: Reorder fields in 'struct clk_fractional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e74c4c93f4bcc6a7af0c3ef5a8edd23.sboyd@kernel.org>
Date:   Wed, 29 Mar 2023 11:46:36 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Michael Turquette <mturquette@...libre.com>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        linux-clk@...r.kernel.org
Subject: Re: [PATCH] clk: Reorder fields in 'struct clk_fractional_divider'

Quoting Christophe JAILLET (2023-02-17 07:55:55)
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index cf1adfeaf257..8cec844f5dde 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -1134,13 +1134,13 @@ struct clk_hw *clk_hw_register_fixed_factor_parent_hw(struct device *dev,
>  struct clk_fractional_divider {
>         struct clk_hw   hw;
>         void __iomem    *reg;
> +       u8              flags;
>         u8              mshift;
>         u8              mwidth;
>         u32             mmask;

This member ...

>         u8              nshift;
>         u8              nwidth;
>         u32             nmask;

and this member can be calculated. Doing that would save more bytes when
combined with this patch. Can you make this into a patch series?

> -       u8              flags;
>         void            (*approximation)(struct clk_hw *hw,
>                                 unsigned long rate, unsigned long *parent_rate,
>                                 unsigned long *m, unsigned long *n);