linux-kernel - Re: [PATCH v2 2/2] drm/amd/display: Mark function 'optc3_wait_drr_doublebuffer_pending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <57f41574-7886-3bfc-c992-74d40664f5ba@amd.com>
Date:   Wed, 29 Mar 2023 15:00:55 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Caio Novais <caionovais@....br>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Cc:     Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Wesley Chalmers <Wesley.Chalmers@....com>,
        "Lee, Alvin" <Alvin.Lee2@....com>, Jun Lei <Jun.Lei@....com>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        Aurabindo Pillai <aurabindo.pillai@....com>,
        Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>,
        Gabe Teeger <gabe.teeger@....com>, Roman Li <roman.li@....com>,
        Maíra Canal <mairacanal@...eup.net>,
        Deepak R Varma <drv@...lo.com>
Subject: Re: [PATCH v2 2/2] drm/amd/display: Mark function
 'optc3_wait_drr_doublebuffer_pending_clear' as static

On 3/29/23 14:05, Caio Novais wrote:
> Compiling AMD GPU drivers displays a warning:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dcn30/dcn30_optc.c:294:6: warning: no previous prototype for ‘optc3_wait_drr_doublebuffer_pending_clear’ [-Wmissing-prototypes]
> 
> Get rid of it by marking the function as static
> 
> Signed-off-by: Caio Novais <caionovais@....br>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> index 08b92715e2e6..c95f000b63b2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_optc.c
> @@ -291,7 +291,7 @@ static void optc3_set_timing_double_buffer(struct timing_generator *optc, bool e
>   		   OTG_DRR_TIMING_DBUF_UPDATE_MODE, mode);
>   }
>   
> -void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
> +static void optc3_wait_drr_doublebuffer_pending_clear(struct timing_generator *optc)
>   {
>   	struct optc *optc1 = DCN10TG_FROM_TG(optc);
>   
-- 
Hamza