linux-kernel - Re: [PATCH] scsi: target: core: remove unused prod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b50e660-f10d-82ae-4a15-86fb575dcab5@nvidia.com>
Date:   Wed, 29 Mar 2023 21:07:36 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Tom Rix <trix@...hat.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "nathan@...nel.org" <nathan@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>
CC:     "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "llvm@...ts.linux.dev" <llvm@...ts.linux.dev>
Subject: Re: [PATCH] scsi: target: core: remove unused prod_len variable

On 3/29/23 06:24, Tom Rix wrote:
> clang with W=1 reports
> drivers/target/target_core_spc.c:229:6: error: variable
>    'prod_len' set but not used [-Werror,-Wunused-but-set-variable]
>          u32 prod_len;
>              ^
> This variable is not used so remove it.
>
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>


Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck