linux-kernel - Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu into helper function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 19:14:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Mike Leach <mike.leach@...aro.org>
Cc:     linux-perf-users@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, coresight@...ts.linaro.org,
        linux-kernel@...r.kernel.org, suzuki.poulose@....com,
        leo.yan@...aro.org, peterz@...radead.org, mingo@...hat.com,
        will@...nel.org, mark.rutland@....com,
        alexander.shishkin@...ux.intel.com, jolsa@...hat.com,
        namhyung@...nel.org, gankulkarni@...amperecomputing.com,
        darren@...amperecomputing.com, James Clark <james.clark@....com>
Subject: Re: [PATCH v8 1/3] perf: cs-etm: Move mapping of Trace ID and cpu
 into helper function

Em Wed, Mar 29, 2023 at 04:28:19PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Mar 29, 2023 at 03:47:25PM +0100, Mike Leach escreveu:
> > On Wed, 29 Mar 2023 at 14:22, Arnaldo Carvalho de Melo <acme@...nel.org> wrote:
> > >
> > > Em Wed, Mar 29, 2023 at 01:59:10PM +0100, Mike Leach escreveu:
> > > > Sorry - my error.
> > > >
> > > > The same change is made in patch 3/3 of this set.
> > > >
> > > > Looks like I didn't do a patch by patch build check when I was testing yesterday
> > >
> > > np, its fixed now and pushed to tmp.perf-tools-next, please check, will
> > > go to perf-tools-next later today after passing thru my set of container
> > > build tests.
> > >
> > > - Arnaldo
> > 
> > tmp.perf-tools-next - Builds and tests OK
> 
> Not here, I'll check after a call:
> 
>   50     9.90 ubuntu:18.04-x-arm            : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
>     arch/arm/util/cs-etm.c: In function 'cs_etm_save_ete_header':
>     arch/arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration]
>       data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu);
>                                  ^~~~~~~~~~~~~~~~~~~~~~

This function was removed in:

Author: Mike Leach <mike.leach@...aro.org>
Date:   Wed Mar 29 12:14:21 2023 +0100

    perf cs-etm: Update record event to use new Trace ID protocol

    Trace IDs are now dynamically allocated.

I'm removing this series from perf-tools-next, please address this issue
and send a v9.

Thanks,

- Arnaldo

>     cc1: all warnings being treated as errors
>     /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed
>     make[5]: *** [util] Error 2
>     /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm' failed
>     make[4]: *** [arm] Error 2
>     /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed
>     make[3]: *** [arch] Error 2
>   51     9.50 ubuntu:18.04-x-arm64          : FAIL gcc version 7.5.0 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04)
>     arch/arm64/util/../../arm/util/cs-etm.c: In function 'cs_etm_save_ete_header':
>     arch/arm64/util/../../arm/util/cs-etm.c:720:29: error: implicit declaration of function 'coresight_get_trace_id' [-Werror=implicit-function-declaration]
>       data[CS_ETE_TRCTRACEIDR] = coresight_get_trace_id(cpu);
>                                  ^~~~~~~~~~~~~~~~~~~~~~
>     cc1: all warnings being treated as errors
>     /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'util' failed
>     make[5]: *** [util] Error 2
>     /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arm64' failed
>     make[4]: *** [arm64] Error 2
>     /git/perf-6.3.0-rc1/tools/build/Makefile.build:140: recipe for target 'arch' failed
>     make[3]: *** [arch] Error 2
>   52    19.34 ubuntu:18.04-x-m68k           : Ok   m68k-linux-gnu-gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0

-- 

- Arnaldo