linux-kernel - Re: [PATCH] clk: tegra20: fix gcc-7 constant overflow warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c9bfdce3487b195acc752fb9625c4dd3.sboyd@kernel.org>
Date:   Wed, 29 Mar 2023 15:32:29 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Michael Turquette <mturquette@...libre.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Miaoqian Lin <linmq006@...il.com>, linux-clk@...r.kernel.org,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: tegra20: fix gcc-7 constant overflow warning

Quoting Arnd Bergmann (2023-02-27 00:59:10)
> From: Arnd Bergmann <arnd@...db.de>
> 
> Older gcc versions get confused by comparing a u32 value to a negative
> constant in a switch()/case block:
> 
> drivers/clk/tegra/clk-tegra20.c: In function 'tegra20_clk_measure_input_freq':
> drivers/clk/tegra/clk-tegra20.c:581:2: error: case label does not reduce to an integer constant
>   case OSC_CTRL_OSC_FREQ_12MHZ:
>   ^~~~
> drivers/clk/tegra/clk-tegra20.c:593:2: error: case label does not reduce to an integer constant
>   case OSC_CTRL_OSC_FREQ_26MHZ:
> 
> Make the constants unsigned instead.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied to clk-next