linux-kernel - RE: [PATCH 0/5] Remove acpi.h implicit include of of.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO1PR11MB508970B2F338C9176CE32DD3D6899@CO1PR11MB5089.namprd11.prod.outlook.com>
Date:   Wed, 29 Mar 2023 23:23:20 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Rob Herring <robh@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Marcelo Schmitt <marcelo.schmitt1@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <Michael.Hennerich@...log.com>,
        Jonathan Cameron <jic23@...nel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        Johannes Berg <johannes@...solutions.net>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        "Marc Zyngier" <maz@...nel.org>
CC:     "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-staging@...ts.linux.dev" <linux-staging@...ts.linux.dev>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-tegra@...r.kernel.org" <linux-tegra@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: RE: [PATCH 0/5] Remove acpi.h implicit include of of.h



> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Wednesday, March 29, 2023 2:21 PM
> To: Rafael J. Wysocki <rafael@...nel.org>; Len Brown <lenb@...nel.org>;
> Marcelo Schmitt <marcelo.schmitt1@...il.com>; Lars-Peter Clausen
> <lars@...afoo.de>; Michael Hennerich <Michael.Hennerich@...log.com>;
> Jonathan Cameron <jic23@...nel.org>; Greg Kroah-Hartman
> <gregkh@...uxfoundation.org>; Johannes Berg <johannes@...solutions.net>;
> David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Jiri Slaby <jirislaby@...nel.org>; Thierry Reding
> <thierry.reding@...il.com>; Jonathan Hunter <jonathanh@...dia.com>; Marc
> Zyngier <maz@...nel.org>
> Cc: linux-iio@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> staging@...ts.linux.dev; linux-wireless@...r.kernel.org;
> netdev@...r.kernel.org; linux-serial@...r.kernel.org; linux-
> tegra@...r.kernel.org; linux-acpi@...r.kernel.org; devicetree@...r.kernel.org
> Subject: [PATCH 0/5] Remove acpi.h implicit include of of.h
> 
> In the process of cleaning up DT includes, I found that some drivers
> using DT functions could build without any explicit DT include. I traced
> the include to be coming from acpi.h via irqdomain.h.
> 
> I was pleasantly surprised that there were not 100s or even 10s of
> warnings when breaking the include chain. So here's the resulting
> series.
> 
> I'd suggest Rafael take the whole series. Alternatively,the fixes can be
> applied in 6.4 and then the last patch either after rc1 or the
> following cycle.
> 

Nice that there aren't too many errors. Use of the forward declarations makes sense rather than including a bunch of unrelated definitions. Nice.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

Thanks,
Jake

> Signed-off-by: Rob Herring <robh@...nel.org>
> ---
> Rob Herring (5):
>       iio: adc: ad7292: Add explicit include for of.h
>       staging: iio: resolver: ad2s1210: Add explicit include for of.h
>       net: rfkill-gpio: Add explicit include for of.h
>       serial: 8250_tegra: Add explicit include for of.h
>       ACPI: Replace irqdomain.h include with struct declarations
> 
>  drivers/iio/adc/ad7292.c                | 1 +
>  drivers/staging/iio/resolver/ad2s1210.c | 1 +
>  drivers/tty/serial/8250/8250_tegra.c    | 1 +
>  include/linux/acpi.h                    | 4 +++-
>  net/rfkill/rfkill-gpio.c                | 1 +
>  5 files changed, 7 insertions(+), 1 deletion(-)
> ---
> base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
> change-id: 20230329-acpi-header-cleanup-665331828436
> 
> Best regards,
> --
> Rob Herring <robh@...nel.org>