linux-kernel - Re: [PATCHv3 02/14] power: supply: core: auto-exposure of simple-battery data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230329232435.rjdzoluxagwy4tvu@mercury.elektranox.org>
Date:   Thu, 30 Mar 2023 01:24:35 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>,
        Matti Vaittinen <mazziesaccount@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCHv3 02/14] power: supply: core: auto-exposure of
 simple-battery data

Hi,

On Fri, Mar 17, 2023 at 11:56:55PM +0100, Sebastian Reichel wrote:
> [...]
> +	/*
> +	 * Expose constant battery info, if it is available. While there are
> +	 * some chargers accessing constant battery data, we only want to
> +	 * expose battery data to userspace for battery devices.
> +	 */
> +	if (desc->type == POWER_SUPPLY_TYPE_BATTERY) {
> +		rc = power_supply_get_battery_info(psy, &psy->battery_info);
> +		if (rc && rc != -ENODEV)
> +			goto check_supplies_failed;

I merged this a few days ago and got a bug report from KernelCI,
that -ENOENT also needs to be handled. I fixed this in place.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)