linux-kernel - Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 10:06:11 +0300
From:   Roger Quadros <rogerq@...nel.org>
To:     Nishanth Menon <nm@...com>
Cc:     vigneshr@...com, kristo@...nel.org, srk@...com,
        r-gunasekaran@...com, linux-arm-kernel@...ts.infradead.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port
 for USB0



On 29/03/2023 00:52, Nishanth Menon wrote:
> On 22:46-20230328, Roger Quadros wrote:
> [...]
>>>>> 	How about sk-lp ?
>>>>
>>>> moved it to sk-lp. see above in this patch.
>>>>
>>>
>>> A bit confused. Looking at [1] vs [2], it seems to indicate pd controller at
>>> 0x3f as well? Am I misreading the schematics?
>>>
>>> [1] https://www.ti.com/tool/SK-AM62-LP#design-files
>>> [2] https://www.ti.com/tool/SK-AM62#design-files
>>
>> Yes PD controller is at 0x3f for both boards but IRQ is not routed on AM62-LP.
>> I tried to explain this the cover letter. ;)
>>
>> Pasting here for convenience.
>>
>>> Although k3-am625-lp-sk USB is exactly the same as on k3-am625-sk,
>>> it is missing the IRQ line from Type-C chip which is currently
>>> required as per chip's DT binding. So we don't add Type-C support
>>> for k3-am625-lp-sk till h/w is fixed or polling mode support for
>>> Type-C chip is accepted [2]
>>>
>>> [2] - https://lore.kernel.org/lkml/20230324133741.43408-1-rogerq@kernel.org/T/
> 
> Thanks, This thread does seem to be progressing? Since LP-SK is already
> in production, it might do good to hold on to this series a little
> longer instead of shuttling dts nodes back and forth.
> 

I agree. This will need a re-spin.

cheers,
-roger