linux-kernel - Re: [PATCH] mfd:i2c: remove redundant dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCPmH0HnqOYp4hpG@hovoldconsulting.com>
Date:   Wed, 29 Mar 2023 09:17:51 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Guiting Shen <aarongt.shen@...il.com>
Cc:     lee@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd:i2c: remove redundant dev_set_drvdata() function

On Wed, Mar 29, 2023 at 01:57:24PM +0800, Guiting Shen wrote:
> the i2c_set_clientdata() is the inline function which is
> complemented by the dev_set_drvdata() internally. Do not
> need to use the i2c_set_clientdata() and dev_set_drvdata()
> at the same time.

In the future please break your commit messages at 72 columns or so (not
60).

Also the Subject should have a space after each colon (or that should
have been a slash, but in this case you should probably just drop the
i2c bit) and it's really not the function that is redundant but the fact
that it is called. Perhaps something like:

	mfd: remove redundant dev_set_drvdata() from i2c drivers
	
> Signed-off-by: Guiting Shen <aarongt.shen@...il.com>
> ---
>  drivers/mfd/88pm80x.c       | 1 -
>  drivers/mfd/88pm860x-core.c | 1 -
>  drivers/mfd/aat2870-core.c  | 2 --
>  drivers/mfd/lm3533-core.c   | 2 --
>  drivers/mfd/max8907.c       | 2 --
>  drivers/mfd/max8925-i2c.c   | 1 -
>  drivers/mfd/wm8400-core.c   | 2 --
>  drivers/mfd/wm8994-core.c   | 2 --
>  8 files changed, 13 deletions(-)

Looks good to me otherwise:

Reviewed-by: Johan Hovold <johan@...nel.org>

Johan