| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <e01a753e-aea2-5489-e436-2ec0f3fedb64@linaro.org>
Date: Wed, 29 Mar 2023 08:18:27 +0100
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: "Yang.Lee" <yang.lee@...ux.alibaba.com>,
broonie <broonie@...nel.org>
Cc: heiko <heiko@...ech.de>, linux-spi <linux-spi@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-rockchip <linux-rockchip@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] spi: rockchip-sfc: Use
devm_platform_get_and_ioremap_resource()
On 3/29/23 07:06, Yang.Lee wrote:
>
> From:Tudor Ambarus <tudor.ambarus@...aro.org>
> Send Time:2023年3月28日(星期二) 23:16
>> If I were you I would make a single patch addressing all the drivers
>> from SPI as this is a single logical change. You get extra points as you
>> avoid polluting the log.
>
> First of all, thank you for pointing out this.
> Because the maintainer list of each SPI driver file is not identical, I am worried about causing trouble for too many people, so I split it into multiple patches based on this.
The change is trivial enough to don't bother at all. Here's an example:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=4b23603a251d24022f2fa48ee67610eb245a4115
>
>> No, you better use devm_platform_ioremap_resource() as res is not used
>> afterwards. You'll get rid of the local variable too.
>
> It's my bad, I will send a new version.
>
> Regards,
> Yang Li
>
Powered by blists - more mailing lists