linux-kernel - Re: [PATCH 3/6] devicetree: input: cypress,tt21000: fix interrupt type in dts example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 10:43:10 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Maximilian Weigand <mweigand@...igand.net>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Alistair Francis <alistair@...stair23.me>
Subject: Re: [PATCH 3/6] devicetree: input: cypress,tt21000: fix interrupt
 type in dts example

On Thu, Mar 23, 2023 at 2:52 PM Maximilian Weigand
<mweigand@...igand.net> wrote:

> Triggering the interrupt of the IRQ_TYPE_LEVEL_LOW type can lead to
> probing issues with the device for the current driver (encountered on
> the Pine64 PineNote). Basically the interrupt would be triggered before
> certain commands were sent to the device, leading to a race between the
> device responding fast enough and the irq handler fetching a data frame
> from it. Actually all devices currently using the driver already use a
> falling edge trigger.
>
> Signed-off-by: Maximilian Weigand <mweigand@...igand.net>
> Reviewed-by: Alistair Francis <alistair@...stair23.me>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij