linux-kernel - Re: [PATCH v1] gpio: mmio: fix calculation of bgpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbc1p_BmGkQRNJYxjNAahJQQ_5+zUadm4fh4UxRmM_PyQ@mail.gmail.com>
Date:   Wed, 29 Mar 2023 10:44:34 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Asmaa Mnebhi <asmaa@...dia.com>
Cc:     andy.shevchenko@...il.com, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] gpio: mmio: fix calculation of bgpio_bits

On Thu, Mar 23, 2023 at 9:57 PM Asmaa Mnebhi <asmaa@...dia.com> wrote:

> If the "ngpios" property is specified, bgpio_bits is calculated
> as the round up value of ngpio. At the moment, the only requirement
> specified is that the round up value must be a multiple of 8 but
> it should also be a power of 2 because we provide accessors based
> on the bank size in bgpio_setup_accessors().
>
> Signed-off-by: Asmaa Mnebhi <asmaa@...dia.com>

Neat fixup,
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij