linux-kernel - Re: [PATCH] mm: compaction: remove incorrect #ifdef checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCP7z7azbdzG254c@bombadil.infradead.org>
Date:   Wed, 29 Mar 2023 01:50:23 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Arnd Bergmann <arnd@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Minghao Chi <chi.minghao@....com.cn>,
        Vlastimil Babka <vbabka@...e.cz>,
        Arnd Bergmann <arnd@...db.de>,
        Miaohe Lin <linmiaohe@...wei.com>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>,
        Mel Gorman <mgorman@...hsingularity.net>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        NARIBAYASHI Akira <a.naribayashi@...itsu.com>,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: compaction: remove incorrect #ifdef checks

On Wed, Mar 29, 2023 at 10:02:41AM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without CONFIG_SYSCTL, the compiler warns about a few unused functions:
> 
> mm/compaction.c:3076:12: error: 'proc_dointvec_minmax_warn_RT_change' defined but not used [-Werror=unused-function]
> mm/compaction.c:2780:12: error: 'sysctl_compaction_handler' defined but not used [-Werror=unused-function]
> mm/compaction.c:2750:12: error: 'compaction_proactiveness_sysctl_handler' defined but not used [-Werror=unused-function]
> 
> The #ifdef is actually not necessary here, as the alternative
> register_sysctl_init() stub function does not use its argument, which
> lets the compiler drop the rest implicitly, while avoiding the warning.
> 
> Fixes: c521126610c3 ("mm: compaction: move compaction sysctl to its own file")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Thanks! Queued up.

  Luis