linux-kernel - Re: [PATCH] fs: quota: avoid unused function warning for !CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230329094407.cpypyfqdwrf7egco@quack3>
Date:   Wed, 29 Mar 2023 11:44:07 +0200
From:   Jan Kara <jack@...e.cz>
To:     Luis Chamberlain <mcgrof@...nel.org>
Cc:     Arnd Bergmann <arnd@...nel.org>, Jan Kara <jack@...e.com>,
        Yangtao Li <frank.li@...o.com>, Arnd Bergmann <arnd@...db.de>,
        Christian Brauner <brauner@...nel.org>,
        Seth Forshee <sforshee@...italocean.com>,
        Dave Chinner <dchinner@...hat.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        Baokun Li <libaokun1@...wei.com>,
        "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: quota: avoid unused function warning for
 !CONFIG_SYSCTL

On Tue 28-03-23 10:48:20, Luis Chamberlain wrote:
> On Tue, Mar 28, 2023 at 02:22:31PM +0200, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@...db.de>
> > Note: it may be better to just revert the 63d00e08515b patch, as the
> > -#ifdef CONFIG_SYSCTL
> > -	if (!register_sysctl("fs/quota", fs_dqstats_table))
> > -		pr_notice("quota sysctl registration failed!\n");
> > -#endif
> > +	if (IS_ENABLED(CONFIG_SYSCTL)) {
> > +		if (!register_sysctl("fs/quota", fs_dqstats_table))
> > +			pr_notice("quota sysctl registration failed!\n");
> > +	}
> 
> I'd agree to drop that patch and instead just use register_sysctl_init()
> iwht Arnd's strategy.

Ah, indeed, register_sysctl_init() is exactly what we need here. I didn't
know about that helper. Thanks for letting me know.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR