linux-kernel - Re: [PATCH v8 char-misc-next 1/5] misc: microchip: pci1xxxx: Fix error handling path in probe function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 11:59:03 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Vaibhaav Ram T.L" <vaibhaavram.tl@...rochip.com>
Cc:     arnd@...db.de, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kumaravel.thiagarajan@...rochip.com,
        tharunkumar.pasumarthi@...rochip.com, UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v8 char-misc-next 1/5] misc: microchip: pci1xxxx: Fix
 error handling path in probe function

On Tue, Mar 28, 2023 at 08:10:04PM +0530, Vaibhaav Ram T.L wrote:
> From: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
> 
> Removed unnecessary header files.

That's not a "fix", it is a cleanup.

> Fix error handling path in probe function.
> Add pci_free_irq_vectors and auxiliary_device_delete in 
> error handling path.

All of these should be individual patches, right?

And you have trailing whitespace here :(

> 
> Fixes: 393fc2f5948f ("misc: microchip: pci1xxxx: load auxiliary bus driver for the PIO function in the multi-function endpoint of pci1xxxx device.")

Is this really a fix of that commit?  What was wrong there, just the
error handling?

> Reported by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Co-developed-by: Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>

No blank line there please.

> Signed-off-by: Tharun Kumar P <tharunkumar.pasumarthi@...rochip.com>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@...rochip.com>
> Signed-off-by: Vaibhaav Ram T.L <vaibhaavram.tl@...rochip.com>
> ---
>  drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c | 104 +++++++++---------
>  1 file changed, 55 insertions(+), 49 deletions(-)
> 
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> index 32af2b14ff34..64302fdfbefc 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gp.c
> @@ -1,16 +1,15 @@
>  // SPDX-License-Identifier: GPL-2.0
> -// Copyright (C) 2022 Microchip Technology Inc.
> +// Copyright (C) 2022-2023 Microchip Technology Inc.
>  
> -#include <linux/mfd/core.h>
> +#include <linux/interrupt.h>
>  #include <linux/module.h>
>  #include <linux/pci.h>
> -#include <linux/spinlock.h>
> -#include <linux/gpio/driver.h>
> -#include <linux/interrupt.h>
> -#include <linux/io.h>
>  #include <linux/idr.h>
> +#include <linux/io.h>
>  #include "mchp_pci1xxxx_gp.h"
>  
> +#define PCI_DRIVER_NAME			"PCI1xxxxGP"

This is not a "fix" but rather a new change.

All of the changes in here are not related, break this up into "one
logical change per patch" please.

thanks,

greg k-h