linux-kernel - Re: [PATCH 02/30] clk: tegra: Don't warn three times about failure to unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce45ed77bb246d98adda4f478c020222.sboyd@kernel.org>
Date:   Tue, 28 Mar 2023 19:34:58 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Jonathan Hunter <jonathanh@...dia.com>,
        Michael Turquette <mturquette@...libre.com>,
        Peter De Schrijver <pdeschrijver@...dia.com>,
        Prashant Gaikwad <pgaikwad@...dia.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     linux-clk@...r.kernel.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/30] clk: tegra: Don't warn three times about failure to unregister

Quoting Uwe Kleine-König (2023-03-12 09:14:44)
> tegra124_dfll_fcpu_remove() calls tegra_dfll_unregister() and the former
> emits an error message if the latter fails. In that case
> tegra_dfll_unregister() already printed an error message. Additionally
> tegra124_dfll_fcpu_remove() returns an error code which results in yet
> another warning emitted by platform_remove().
> 
> So drop the error message from tegra124_dfll_fcpu_remove() and let it
> return 0. (Retuning 0 has no side effect but suppressing the error
> message in platform_remove().)
> 
> Also add two comments about exiting early being wrong. This is something
> that needs fixing separately.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---

Applied to clk-next