linux-kernel - Re: [PATCH] docs: driver-api: firmware_loader: fix missing argument in usage example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 16:09:13 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Conor Dooley <conor.dooley@...rochip.com>
Cc:     corbet@....net, conor@...nel.org,
        Russ Weight <russell.h.weight@...el.com>,
        Tianfei zhang <tianfei.zhang@...el.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: driver-api: firmware_loader: fix missing argument
 in usage example

On Wed, Mar 29, 2023 at 01:34:26PM +0100, Conor Dooley wrote:
> By the time firmware-upload support landed in commit 97730bbb242c
> ("firmware_loader: Add firmware-upload support"), the arguments for
> firmware_upload_register() had changed, and while this is automagically
> represented in the kernel doc bits, the usage example was not kept in
> sync.
> Add the missing argument as per the driver.
> 
> Fixes: 97730bbb242c ("firmware_loader: Add firmware-upload support")
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> >From skimming the threads adding this stuff, looks like THIS_MODULE was
> always needed, so either I'm missing something or the doc stuff wasn't
> matching in any of the submitted versions.
> 
> CC: Jonathan Corbet <corbet@....net>
> CC: Russ Weight <russell.h.weight@...el.com>
> CC: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> CC: Tianfei zhang <tianfei.zhang@...el.com>
> CC: Luis Chamberlain <mcgrof@...nel.org>
> CC: linux-doc@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> ---
>  Documentation/driver-api/firmware/fw_upload.rst | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/driver-api/firmware/fw_upload.rst b/Documentation/driver-api/firmware/fw_upload.rst
> index 76922591e446..edf1d0c5e7c3 100644
> --- a/Documentation/driver-api/firmware/fw_upload.rst
> +++ b/Documentation/driver-api/firmware/fw_upload.rst
> @@ -57,7 +57,8 @@ function calls firmware_upload_unregister() such as::
>  		len = (truncate) ? truncate - fw_name : strlen(fw_name);
>  		sec->fw_name = kmemdup_nul(fw_name, len, GFP_KERNEL);
>  
> -		fwl = firmware_upload_register(sec->dev, sec->fw_name, &m10bmc_ops, sec);
> +		fwl = firmware_upload_register(THIS_MODULE, sec->dev, sec->fw_name,
> +					       &m10bmc_ops, sec);

Good catch.  As this touches the firmware documentation, I can take it
in my tree, thanks!

greg k-h