linux-kernel - Re: [PATCH v3] iommu/rockchip: Add missing set_platform_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCWsC38WGyZi3Y0p@nvidia.com>
Date:   Thu, 30 Mar 2023 12:34:35 -0300
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Robin Murphy <robin.murphy@....com>
Cc:     Steven Price <steven.price@....com>,
        Heiko Stuebner <heiko@...ech.de>,
        Joerg Roedel <joro@...tes.org>, Will Deacon <will@...nel.org>,
        iommu@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-rockchip@...ts.infradead.org,
        John Keeping <john@...anate.com>
Subject: Re: [PATCH v3] iommu/rockchip: Add missing set_platform_dma_ops
 callback

On Thu, Mar 30, 2023 at 04:09:03PM +0100, Robin Murphy wrote:

> > +static struct iommu_domain_ops rk_identity_ops = {
> > +	.attach_dev = rk_iommu_identity_attach,
> 
> Since it's going to behave like a regular identity domain and be treated as
> one, it needs to support .free as well.

It would be nice to provide some

static void iommu_domain_static_free(struct iommu_domain *){}

Or adjust the core code so NULL is OK..

I think this pattern of static singleton will be popular. I drafted a
patch for the DART driver like this too

Thanks,
Jason