linux-kernel - Re: [PING PATCH v4 27/29] LoongArch: KVM: Implement vcpu world switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <11fefc2b-63e4-a4a8-94c7-c4e312aa4958@loongson.cn>
Date:   Thu, 30 Mar 2023 11:41:35 +0800
From:   Tianrui Zhao <zhaotianrui@...ngson.cn>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Huacai Chen <chenhuacai@...nel.org>,
        WANG Xuerui <kernel@...0n.name>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        loongarch@...ts.linux.dev, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
        Mark Brown <broonie@...nel.org>,
        Alex Deucher <alexander.deucher@....com>,
        Oliver Upton <oliver.upton@...ux.dev>, maobibo@...ngson.cn,
        Xi Ruoyao <xry111@...111.site>
Subject: Re: [PING PATCH v4 27/29] LoongArch: KVM: Implement vcpu world switch



在 2023年03月28日 22:13, Paolo Bonzini 写道:
> On 3/28/23 14:31, Tianrui Zhao wrote:
>> + * prepare switch to guest
>> + * @param:
>> + *  KVM_ARCH: kvm_vcpu_arch, don't touch it until 'ertn'
>> + *  GPRNUM: KVM_ARCH gpr number
>
> Stale comment (should be "a2: kvm_vcpu_arch, don't touch it until 
> 'ertn'").
>
> Since you are at it, I noticed now that tmp and tmp1 aren't too useful 
> because all registers will be overwritten before the end of the macro. 
> You choose whether to keep or remove them.
>
> Paolo

Thanks, I will fix the stale comment and remove the tmp,tmp1 argument 
and replace it with t0,t1 reg.

Thanks
Tianrui Zhao

>
>> + *  tmp, tmp1: temp register
>> + */