linux-kernel - Re: [PATCH] MFD: dln2: fix memory leak in dln2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230330170705.GB548901@google.com>
Date:   Thu, 30 Mar 2023 18:07:05 +0100
From:   Lee Jones <lee@...nel.org>
To:     Qiang Ning <qning0106@....com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MFD: dln2: fix memory leak in dln2_probe

On Thu, 30 Mar 2023, Qiang Ning wrote:

> When dln2_setup_rx_urbs() in dln2_probe() fails, error out_free
> forgets to call  usb_put_dev to decrease the refcount of
> dln2->usb_dev.
>
> Fix this by adding usb_put_dev() in the error handling code
> of dln2_probe().
>
> Signed-off-by: Qiang Ning <qning0106@....com>
> ---
>  drivers/mfd/dln2.c | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks

--
Lee Jones [李琼斯]