linux-kernel - Re: [PATCH v6 2/2] arm64: dts: mediatek: enable i2c0 for mt8365-evk board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c654905d-a8c8-fafb-b8c5-2992b7cac0d8@gmail.com>
Date:   Thu, 30 Mar 2023 19:14:41 +0200
From:   Matthias Brugger <matthias.bgg@...il.com>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Alexandre Mergnat <amergnat@...libre.com>,
        Qii Wang <qii.wang@...iatek.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Cc:     linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Fabien Parent <fparent@...libre.com>,
        Rob Herring <robh@...nel.org>
Subject: Re: [PATCH v6 2/2] arm64: dts: mediatek: enable i2c0 for mt8365-evk
 board



On 28/03/2023 12:04, AngeloGioacchino Del Regno wrote:
> Il 28/03/23 11:04, Alexandre Mergnat ha scritto:
>> Enable the I2C0 bus provides communication with:
>> - The integrated RT9466 Switching Battery Charger.
>> - The integrated MT6691 LP4X buck for VDDQ.
>> - The integrated MT6691 LP4X buck for VDD2.
>> - The pin header, to plug external I2C devices.
>>
>> Signed-off-by: Alexandre Mergnat <amergnat@...libre.com>
>> ---
>>   arch/arm64/boot/dts/mediatek/mt8365-evk.dts | 15 +++++++++++++++
>>   1 file changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts 
>> b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
>> index 4683704ea235..adc79ba14b33 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
>> +++ b/arch/arm64/boot/dts/mediatek/mt8365-evk.dts
>> @@ -87,6 +87,13 @@ optee_reserved: optee@...00000 {
>>       };
>>   };
>> +&i2c0 {
>> +    clock-frequency = <100000>;
>> +    pinctrl-0 = <&i2c0_pins>;
>> +    pinctrl-names = "default";
>> +    status = "okay";
>> +};
>> +
>>   &pio {
>>       gpio_keys: gpio-keys-pins {
>>           pins {
>> @@ -96,6 +103,14 @@ pins {
>>           };
>>       };
>> +    i2c0_pins: i2c0-pins {
>> +        pins {
>> +            bias-pull-up;
> 
> I prefer seeing pinmux first, any other properties last....
> If Matthias can please fix that while applying...
> 

Done and queued the whole series.

Thanks!
Matthias

> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> 
>