linux-kernel - Re: [PATCH] thermal: intel: powerclamp: Fix cpumask and max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e65a37b8220943a540cc3aaf660a79cef4041dc.camel@linux.intel.com>
Date:   Thu, 30 Mar 2023 10:36:33 -0700
From:   srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     David Arcari <darcari@...hat.com>, linux-pm@...r.kernel.org
Cc:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amitk@...nel.org>,
        Zhang Rui <rui.zhang@...el.com>, Chen Yu <yu.c.chen@...el.com>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] thermal: intel: powerclamp: Fix cpumask and max_idle
 module parameters

On Thu, 2023-03-30 at 09:42 -0400, David Arcari wrote:
Reviewed-by: Srinivas Pandruvada <>> When cpumask is specified as a module parameter the value is
> overwritten by the module init routine.  This can easily be fixed
> by checking to see if the mask has already been allocated in the
> init routine.
> 
> When max_idle is specified as a module parameter a panic will occur.
> The problem is that the idle_injection_cpu_mask is not allocated
> until
> the module init routine executes. This can easily be fixed by
> allocating
> the cpumask if it's not already allocated.
> 
> Fixes: ebf519710218 ("thermal: intel: powerclamp: Add two module
> parameters")
> 
> Signed-off-by: David Arcari <darcari@...hat.com>
Reviewed-by: Srinivas Pandruvada<srinivas.pandruvada@...ux.intel.com>

> 
> Cc: "Rafael J. Wysocki" <rafael@...nel.org>
> Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Amit Kucheria <amitk@...nel.org>
> Cc: Zhang Rui <rui.zhang@...el.com>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
> Cc: David Arcari <darcari@...hat.com>
> Cc: Chen Yu <yu.c.chen@...el.com>
> Cc: linux-kernel@...r.kernel.org
> Cc: stable@...r.kernel.org
> 
> ---
>  drivers/thermal/intel/intel_powerclamp.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/intel_powerclamp.c
> b/drivers/thermal/intel/intel_powerclamp.c
> index c7ba5680cd48..91fc7e239497 100644
> --- a/drivers/thermal/intel/intel_powerclamp.c
> +++ b/drivers/thermal/intel/intel_powerclamp.c
> @@ -235,6 +235,12 @@ static int max_idle_set(const char *arg, const
> struct kernel_param *kp)
>                 goto skip_limit_set;
>         }
>  
> +       if (!cpumask_available(idle_injection_cpu_mask)) {
> +               ret =
> allocate_copy_idle_injection_mask(cpu_present_mask);
> +               if (ret)
> +                       goto skip_limit_set;
> +       }
> +
>         if (check_invalid(idle_injection_cpu_mask, new_max_idle)) {
>                 ret = -EINVAL;
>                 goto skip_limit_set;
> @@ -791,7 +797,8 @@ static int __init powerclamp_init(void)
>                 return retval;
>  
>         mutex_lock(&powerclamp_lock);
> -       retval = allocate_copy_idle_injection_mask(cpu_present_mask);
> +       if (!cpumask_available(idle_injection_cpu_mask))
> +               retval =
> allocate_copy_idle_injection_mask(cpu_present_mask);
>         mutex_unlock(&powerclamp_lock);
>  
>         if (retval)