linux-kernel - RE: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <DM6PR12MB30823A9CA118E1890BAC2260E88E9@DM6PR12MB3082.namprd12.prod.outlook.com>
Date:   Thu, 30 Mar 2023 04:34:02 +0000
From:   "Gupta, Nipun" <Nipun.Gupta@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "eric.auger@...hat.com" <eric.auger@...hat.com>,
        "alex.williamson@...hat.com" <alex.williamson@...hat.com>,
        "cohuck@...hat.com" <cohuck@...hat.com>,
        "song.bao.hua@...ilicon.com" <song.bao.hua@...ilicon.com>,
        "mchehab+huawei@...nel.org" <mchehab+huawei@...nel.org>,
        "maz@...nel.org" <maz@...nel.org>,
        "f.fainelli@...il.com" <f.fainelli@...il.com>,
        "jeffrey.l.hugo@...il.com" <jeffrey.l.hugo@...il.com>,
        "saravanak@...gle.com" <saravanak@...gle.com>,
        "Michael.Srba@...nam.cz" <Michael.Srba@...nam.cz>,
        "mani@...nel.org" <mani@...nel.org>,
        "yishaih@...dia.com" <yishaih@...dia.com>,
        "jgg@...pe.ca" <jgg@...pe.ca>, "jgg@...dia.com" <jgg@...dia.com>,
        "robin.murphy@....com" <robin.murphy@....com>,
        "will@...nel.org" <will@...nel.org>,
        "joro@...tes.org" <joro@...tes.org>,
        "masahiroy@...nel.org" <masahiroy@...nel.org>,
        "ndesaulniers@...gle.com" <ndesaulniers@...gle.com>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "baolu.lu@...ux.intel.com" <baolu.lu@...ux.intel.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kbuild@...r.kernel.org" <linux-kbuild@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "okaya@...nel.org" <okaya@...nel.org>,
        "Anand, Harpreet" <harpreet.anand@....com>,
        "Agarwal, Nikhil" <nikhil.agarwal@....com>,
        "Simek, Michal" <michal.simek@....com>,
        "Jansen Van Vuuren, Pieter" <pieter.jansen-van-vuuren@....com>,
        "Cascon, Pablo" <pablo.cascon@....com>,
        "git (AMD-Xilinx)" <git@....com>
Subject: RE: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus

[AMD Official Use Only - General]


> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Wednesday, March 29, 2023 3:56 PM
> To: Gupta, Nipun <Nipun.Gupta@....com>
> Cc: robh+dt@...nel.org; krzysztof.kozlowski+dt@...aro.org;
> rafael@...nel.org; eric.auger@...hat.com; alex.williamson@...hat.com;
> cohuck@...hat.com; song.bao.hua@...ilicon.com;
> mchehab+huawei@...nel.org; maz@...nel.org; f.fainelli@...il.com;
> jeffrey.l.hugo@...il.com; saravanak@...gle.com;
> Michael.Srba@...nam.cz; mani@...nel.org; yishaih@...dia.com;
> jgg@...pe.ca; jgg@...dia.com; robin.murphy@....com; will@...nel.org;
> joro@...tes.org; masahiroy@...nel.org; ndesaulniers@...gle.com;
> rdunlap@...radead.org; baolu.lu@...ux.intel.com; linux-arm-
> kernel@...ts.infradead.org; linux-kbuild@...r.kernel.org; linux-
> kernel@...r.kernel.org; devicetree@...r.kernel.org; okaya@...nel.org;
> Anand, Harpreet <harpreet.anand@....com>; Agarwal, Nikhil
> <nikhil.agarwal@....com>; Simek, Michal <michal.simek@....com>;
> Jansen Van Vuuren, Pieter <pieter.jansen-van-vuuren@....com>; Cascon,
> Pablo <pablo.cascon@....com>; git (AMD-Xilinx) <git@....com>
> Subject: Re: [PATCH v10 2/7] iommu: Add iommu probe for CDX bus
> 
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
> 
> 
> On Mon, Mar 13, 2023 at 06:56:31PM +0530, Nipun Gupta wrote:
> > Add CDX bus to iommu_buses so that IOMMU probe is called
> > for it.
> >
> > Signed-off-by: Nipun Gupta <nipun.gupta@....com>
> > Reviewed-by: Pieter Jansen van Vuuren <pieter.jansen-van-
> vuuren@....com>
> > Reviewed-by: Lu Baolu <baolu.lu@...ux.intel.com>
> > Tested-by: Nikhil Agarwal <nikhil.agarwal@....com>
> > ---
> >  drivers/iommu/iommu.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> > index 10db680acaed..0025a631b8e1 100644
> > --- a/drivers/iommu/iommu.c
> > +++ b/drivers/iommu/iommu.c
> > @@ -28,6 +28,7 @@
> >  #include <linux/fsl/mc.h>
> >  #include <linux/module.h>
> >  #include <linux/cc_platform.h>
> > +#include <linux/cdx/cdx_bus.h>
> >  #include <trace/events/iommu.h>
> >  #include <linux/sched/mm.h>
> >  #include <linux/msi.h>
> > @@ -129,6 +130,9 @@ static struct bus_type * const iommu_buses[] = {
> >  #ifdef CONFIG_TEGRA_HOST1X_CONTEXT_BUS
> >       &host1x_context_device_bus_type,
> >  #endif
> > +#ifdef CONFIG_CDX_BUS
> > +     &cdx_bus_type,
> > +#endif
> >  };
> 
> Note, this prevents the ability for this struct bus_type from being
> moved into read-only memory in the future.  But hopefully that will be
> fixed up eventually, you are in good company with some other busses
> here...
> 
> Other than that, this series looks good, I'll queue this up through my
> tree for now as I seem to collect new subsystems.  Feel free to send
> future patches through me as well until you get tired of that and want
> to send stuff to Linus directly.

Thanks, Greg, for the review and helping get the series in : )

Regards,
Nipun

> 
> thanks,
> 
> greg k-h