linux-kernel - Re: [PATCH v1 1/3] perf bench: Avoid NDEBUG warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZCX7B/7ikbbie/FD@kernel.org>
Date:   Thu, 30 Mar 2023 18:11:35 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] perf bench: Avoid NDEBUG warning

Em Thu, Mar 30, 2023 at 11:38:25AM -0700, Ian Rogers escreveu:
> With NDEBUG set the asserts are compiled out. This yields
> "unused-but-set-variable" variables. Move these variables behind
> NDEBUG to avoid the warning.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/perf/bench/find-bit-bench.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/bench/find-bit-bench.c b/tools/perf/bench/find-bit-bench.c
> index d103c3136983..7e25b0e413f6 100644
> --- a/tools/perf/bench/find-bit-bench.c
> +++ b/tools/perf/bench/find-bit-bench.c
> @@ -61,7 +61,6 @@ static int do_for_each_set_bit(unsigned int num_bits)
>  	double time_average, time_stddev;
>  	unsigned int bit, i, j;
>  	unsigned int set_bits, skip;
> -	unsigned int old;
>  
>  	init_stats(&fb_time_stats);
>  	init_stats(&tb_time_stats);
> @@ -73,7 +72,10 @@ static int do_for_each_set_bit(unsigned int num_bits)
>  			__set_bit(i, to_test);
>  
>  		for (i = 0; i < outer_iterations; i++) {
> -			old = accumulator;
> +#ifndef NDEBUG
> +			unsigned int old = accumulator;
> +#endif
> +
>  			gettimeofday(&start, NULL);
>  			for (j = 0; j < inner_iterations; j++) {
>  				for_each_set_bit(bit, to_test, num_bits)
> @@ -85,7 +87,9 @@ static int do_for_each_set_bit(unsigned int num_bits)
>  			runtime_us = diff.tv_sec * USEC_PER_SEC + diff.tv_usec;
>  			update_stats(&fb_time_stats, runtime_us);
>  
> +#ifndef NDEBUG
>  			old = accumulator;
> +#endif
>  			gettimeofday(&start, NULL);
>  			for (j = 0; j < inner_iterations; j++) {
>  				for (bit = 0; bit < num_bits; bit++) {
> -- 
> 2.40.0.348.gf938b09366-goog
> 

-- 

- Arnaldo